Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chatbot] Add feature flags for traces and feedback #379

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

000FLMS
Copy link
Contributor

@000FLMS 000FLMS commented Dec 20, 2024

Description

Add feature flags to traces and feedback.

Issues Resolved

Add flags in the config to control the trace view and feedback buttons in message bubbles.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (581a7ca) to head (93a8591).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
+ Coverage   87.46%   87.49%   +0.02%     
==========================================
  Files          65       65              
  Lines        1891     1895       +4     
  Branches      473      475       +2     
==========================================
+ Hits         1654     1658       +4     
  Misses        236      236              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sihan He <[email protected]>
@000FLMS 000FLMS changed the title [Chatbot] Add flag to disable traces [Chatbot] Add feature flags to traces and feedback Dec 25, 2024
@000FLMS 000FLMS changed the title [Chatbot] Add feature flags to traces and feedback [Chatbot] Add feature flags for traces and feedback Dec 25, 2024
Signed-off-by: Sihan He <[email protected]>
Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great to me!

@ruanyl ruanyl added the backport 2.x Trigger the backport flow to 2.x label Dec 27, 2024
@ruanyl ruanyl merged commit 4671d7c into opensearch-project:main Dec 27, 2024
11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 27, 2024
* Add flag for trace view

Signed-off-by: Sihan He <[email protected]>

* update change log

Signed-off-by: Sihan He <[email protected]>

* Add feedback flag

Signed-off-by: Sihan He <[email protected]>

* Update change log

Signed-off-by: Sihan He <[email protected]>

---------

Signed-off-by: Sihan He <[email protected]>
(cherry picked from commit 4671d7c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ruanyl pushed a commit that referenced this pull request Jan 6, 2025
* Add flag for trace view

Signed-off-by: Sihan He <[email protected]>

* update change log

Signed-off-by: Sihan He <[email protected]>

* Add feedback flag

Signed-off-by: Sihan He <[email protected]>

* Update change log

Signed-off-by: Sihan He <[email protected]>

---------

Signed-off-by: Sihan He <[email protected]>
(cherry picked from commit 4671d7c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Trigger the backport flow to 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants