-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chatbot] Add feature flags for traces and feedback #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihan He <[email protected]>
000FLMS
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
December 20, 2024 04:07
Signed-off-by: Sihan He <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 87.46% 87.49% +0.02%
==========================================
Files 65 65
Lines 1891 1895 +4
Branches 473 475 +2
==========================================
+ Hits 1654 1658 +4
Misses 236 236
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sihan He <[email protected]>
000FLMS
changed the title
[Chatbot] Add flag to disable traces
[Chatbot] Add feature flags to traces and feedback
Dec 25, 2024
000FLMS
changed the title
[Chatbot] Add feature flags to traces and feedback
[Chatbot] Add feature flags for traces and feedback
Dec 25, 2024
Signed-off-by: Sihan He <[email protected]>
000FLMS
force-pushed
the
messageAction
branch
from
December 25, 2024 03:14
6cea954
to
b85a199
Compare
ruanyl
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great to me!
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 27, 2024
* Add flag for trace view Signed-off-by: Sihan He <[email protected]> * update change log Signed-off-by: Sihan He <[email protected]> * Add feedback flag Signed-off-by: Sihan He <[email protected]> * Update change log Signed-off-by: Sihan He <[email protected]> --------- Signed-off-by: Sihan He <[email protected]> (cherry picked from commit 4671d7c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ruanyl
pushed a commit
that referenced
this pull request
Jan 6, 2025
* Add flag for trace view Signed-off-by: Sihan He <[email protected]> * update change log Signed-off-by: Sihan He <[email protected]> * Add feedback flag Signed-off-by: Sihan He <[email protected]> * Update change log Signed-off-by: Sihan He <[email protected]> --------- Signed-off-by: Sihan He <[email protected]> (cherry picked from commit 4671d7c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add feature flags to traces and feedback.
Issues Resolved
Add flags in the config to control the trace view and feedback buttons in message bubbles.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.