Add standalone form state for advanced transform modals (#456) (#459)

(cherry picked from commit 500e671) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project · Oct 31, 2024 · 14702b8 · 14702b8
1 parent 11da61a
commit 14702b8
Show file tree

Hide file tree

Showing 5 changed files with 947 additions and 727 deletions.
diff --git a/common/interfaces.ts b/common/interfaces.ts
@@ -122,6 +122,20 @@ export type RequestFormValues = {
 };
 export type RequestSchema = WorkflowSchema;
 
+// Form / schema interfaces for the input transform sub-form
+export type InputTransformFormValues = {
+  input_map: MapArrayFormValue;
+  one_to_one: ConfigFieldValue;
+};
+export type InputTransformSchema = WorkflowSchema;
+
+// Form / schema interfaces for the output transform sub-form
+export type OutputTransformFormValues = {
+  output_map: MapArrayFormValue;
+  full_response_path: ConfigFieldValue;
+};
+export type OutputTransformSchema = WorkflowSchema;
+
 /**
  ********** WORKSPACE TYPES/INTERFACES **********
  */

diff --git a/public/pages/workflow_detail/workflow_inputs/input_fields/map_array_field.tsx b/public/pages/workflow_detail/workflow_inputs/input_fields/map_array_field.tsx
@@ -18,15 +18,13 @@ import {
 import { Field, FieldProps, getIn, useFormikContext } from 'formik';
 import {
   EMPTY_MAP_ENTRY,
-  IConfigField,
   MapArrayFormValue,
   MapEntry,
   WorkflowFormValues,
 } from '../../../../../common';
 import { MapField } from './map_field';
 
 interface MapArrayFieldProps {
-  field: IConfigField;
   fieldPath: string; // the full path in string-form to the field (e.g., 'ingest.enrich.processors.text_embedding_processor.inputField')
   helpText?: string;
   keyTitle?: string;

diff --git a/public/pages/workflow_detail/workflow_inputs/processor_inputs/ml_processor_inputs.tsx b/public/pages/workflow_detail/workflow_inputs/processor_inputs/ml_processor_inputs.tsx
@@ -25,7 +25,6 @@ import {
   PROCESSOR_CONTEXT,
   WorkflowConfig,
   JSONPATH_ROOT_SELECTOR,
-  ML_INFERENCE_DOCS_LINK,
   WorkflowFormValues,
   ModelInterface,
   IndexMappings,
@@ -75,15 +74,9 @@ export function MLProcessorInputs(props: MLProcessorInputsProps) {
   ) as IConfigField;
   const modelFieldPath = `${props.baseConfigPath}.${props.config.id}.${modelField.id}`;
   const modelIdFieldPath = `${modelFieldPath}.id`;
-  const inputMapField = props.config.fields.find(
-    (field) => field.id === 'input_map'
-  ) as IConfigField;
-  const inputMapFieldPath = `${props.baseConfigPath}.${props.config.id}.${inputMapField.id}`;
+  const inputMapFieldPath = `${props.baseConfigPath}.${props.config.id}.input_map`;
   const inputMapValue = getIn(values, inputMapFieldPath);
-  const outputMapField = props.config.fields.find(
-    (field) => field.id === 'output_map'
-  ) as IConfigField;
-  const outputMapFieldPath = `${props.baseConfigPath}.${props.config.id}.${outputMapField.id}`;
+  const outputMapFieldPath = `${props.baseConfigPath}.${props.config.id}.output_map`;
   const outputMapValue = getIn(values, outputMapFieldPath);
   const fullResponsePath = getIn(
     values,
@@ -250,7 +243,6 @@ export function MLProcessorInputs(props: MLProcessorInputsProps) {
           config={props.config}
           baseConfigPath={props.baseConfigPath}
           context={props.context}
-          inputMapField={inputMapField}
           inputMapFieldPath={inputMapFieldPath}
           modelInterface={modelInterface}
           valueOptions={
@@ -269,7 +261,6 @@ export function MLProcessorInputs(props: MLProcessorInputsProps) {
           config={props.config}
           baseConfigPath={props.baseConfigPath}
           context={props.context}
-          outputMapField={outputMapField}
           outputMapFieldPath={outputMapFieldPath}
           modelInterface={modelInterface}
           onClose={() => setIsOutputTransformModalOpen(false)}
@@ -365,7 +356,6 @@ export function MLProcessorInputs(props: MLProcessorInputsProps) {
           </EuiFlexGroup>
           <EuiSpacer size="s" />
           <MapArrayField
-            field={inputMapField}
             fieldPath={inputMapFieldPath}
             helpText={`An array specifying how to map fields from the ingested document to the model’s input. Dot notation is used by default. To explicitly use JSONPath, please ensure to prepend with the
             root object selector "${JSONPATH_ROOT_SELECTOR}"`}
@@ -422,7 +412,6 @@ export function MLProcessorInputs(props: MLProcessorInputsProps) {
           </EuiFlexGroup>
           <EuiSpacer size="s" />
           <MapArrayField
-            field={outputMapField}
             fieldPath={outputMapFieldPath}
             helpText={`An array specifying how to map the model’s output to new document fields. Dot notation is used by default. To explicitly use JSONPath, please ensure to prepend with the
             root object selector "${JSONPATH_ROOT_SELECTOR}"`}