Fix MDS bug (#530)

* Fix MDS bug Signed-off-by: saimedhi <[email protected]> --------- Signed-off-by: saimedhi <[email protected]>
opensearch-project · Dec 13, 2024 · 81969fb · 81969fb
1 parent b613ce3
commit 81969fb
Showing 1 changed file with 33 additions and 21 deletions.
diff --git a/public/pages/workflows/workflows.tsx b/public/pages/workflows/workflows.tsx
@@ -102,6 +102,9 @@ export function Workflows(props: WorkflowsProps) {
     escape(tabFromUrl) as WORKFLOWS_TAB
   );
 
+  const isDataSourceReady =
+    !dataSourceEnabled || (dataSourceId && dataSourceId !== '');
+
   // If there is no selected tab or invalid tab, default to manage tab
   useEffect(() => {
     if (
@@ -116,14 +119,17 @@ export function Workflows(props: WorkflowsProps) {
   // If the user navigates back to the manage tab, re-fetch workflows
   useEffect(() => {
     if (selectedTabId === WORKFLOWS_TAB.MANAGE) {
-      dispatch(
-        searchWorkflows({
-          apiBody: FETCH_ALL_QUERY,
-          dataSourceId: dataSourceId,
-        })
-      );
+      // wait until selected data source is ready before doing dispatch calls if mds is enabled
+      if (isDataSourceReady) {
+        dispatch(
+          searchWorkflows({
+            apiBody: FETCH_ALL_QUERY,
+            dataSourceId: dataSourceId,
+          })
+        );
+      }
     }
-  }, [selectedTabId]);
+  }, [selectedTabId, dataSourceId, dataSourceEnabled]);
 
   useEffect(() => {
     setBreadcrumbs(
@@ -138,13 +144,16 @@ export function Workflows(props: WorkflowsProps) {
 
   // On initial render: fetch all workflows
   useEffect(() => {
-    dispatch(
-      searchWorkflows({
-        apiBody: FETCH_ALL_QUERY,
-        dataSourceId: dataSourceId,
-      })
-    );
-  }, []);
+    // wait until selected data source is ready before doing dispatch calls if mds is enabled
+    if (isDataSourceReady) {
+      dispatch(
+        searchWorkflows({
+          apiBody: FETCH_ALL_QUERY,
+          dataSourceId: dataSourceId,
+        })
+      );
+    }
+  }, [dataSourceId, dataSourceEnabled]);
 
   useEffect(() => {
     const { history, location } = props;
@@ -158,13 +167,16 @@ export function Workflows(props: WorkflowsProps) {
         search: queryString.stringify(updatedParams),
       });
     }
-    dispatch(
-      searchWorkflows({
-        apiBody: FETCH_ALL_QUERY,
-        dataSourceId: dataSourceId,
-      })
-    );
-  }, [dataSourceId, setDataSourceId]);
+    // wait until selected data source is ready before doing dispatch calls if mds is enabled
+    if (isDataSourceReady) {
+      dispatch(
+        searchWorkflows({
+          apiBody: FETCH_ALL_QUERY,
+          dataSourceId: dataSourceId,
+        })
+      );
+    }
+  }, [dataSourceId, setDataSourceId, dataSourceEnabled]);
 
   const handleDataSourceChange = ([event]: DataSourceOption[]) => {
     const dataSourceEventId = event?.id;