-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make New Workflow page functional #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
March 1, 2024 20:48
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 17.41% 19.30% +1.89%
==========================================
Files 49 50 +1
Lines 695 746 +51
Branches 63 71 +8
==========================================
+ Hits 121 144 +23
- Misses 569 595 +26
- Partials 5 7 +2 ☔ View full report in Codecov by Sentry. |
dbwiddis
approved these changes
Mar 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 2d176f0)
ohltyler
added a commit
that referenced
this pull request
Mar 4, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 2d176f0) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the New Workflow page functional via the following changes:
Go
button functional and navigate to the workflow details page with pre-filled dataChanges on the Workflow Details page to support the navigation from New Workflow page:
new
constant in the URL and process it to determine if the context of the page is a new workflow, or some existing/indexed workflowOther minor changes:
Workflow
data model to have more optional params, in the case of a new/unsaved workflowloading
fieldDemo video showing:
new_workflow
namescreen-capture.15.webm
Issues Resolved
Resolves #71
Leaving #72 open until a preset workflow library is available from the backend.
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.