Parse and persist UI metadata on editor page #125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds end-to-end support of saving to, and reading from, the
ui_metadata
field in the indexed workflow:processNodes()
to use the newly-implementedformikToComponentData()
to update the underlyingdata
field with the form valuesprocessNodes()
which was limiting the fields that were saved. Defaulting to all fields now, so other metadata likeposition
,positionAbsolute
,extent
,parentNode
, etc. are saved. This allows proper functionality for the parent/child nodes that we have (e.g., nodes insideIngest
block), and nice-to-haves, like the exact node positioning within the viewport staying static such that reloads will still show the view exactly how the user last left itui_metadata
parsing in server-side when fetching workflows viasearchWorkflows()
props.workflow
inResizableWorkspace
to only parse the state when there is a valid workflow. This is to prevent weird intermediate states where it may render a default/invalid template immediately before the target workflow is fetched and rendered on top. instead, we leave it empty and don't populate any nodes/edges until that the workflow is availableMisc changes:
IComponentField
fromname
->id
for consistencyDemo video:
Formik
<Form>
screen-capture.26.webm
Issues Resolved
Makes progress on #75
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.