Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor model input/output transform configurations #492

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

ohltyler
Copy link
Member

Description

Refactors the components of the model input / output transforms into standalone components. This is the first step in #491.
Subsequent PRs may be going to a feature branch.

Issues Resolved

Makes progress on #491

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <[email protected]>
Copy link
Collaborator

@saimedhi saimedhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested this code .

@saimedhi saimedhi merged commit c2f05e4 into opensearch-project:main Nov 20, 2024
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 20, 2024
* Refactor MLProcessorInputs

Signed-off-by: Tyler Ohlsen <[email protected]>

* Refactor ML processor modals

Signed-off-by: Tyler Ohlsen <[email protected]>

* Refactor model inputs/outputs to standalone components

Signed-off-by: Tyler Ohlsen <[email protected]>

* Revert interface change for now

Signed-off-by: Tyler Ohlsen <[email protected]>

* Remove log

Signed-off-by: Tyler Ohlsen <[email protected]>

---------

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit c2f05e4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ohltyler ohltyler deleted the input-types branch November 20, 2024 20:07
ohltyler pushed a commit that referenced this pull request Nov 20, 2024

(cherry picked from commit c2f05e4)

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants