Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with synchronous provisioning feature #591

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ohltyler
Copy link
Member

Description

Updates few of the provisioning-related API calls to leverage new params offered to enforce synchronous provisioning with a configurable timeout - see PR: opensearch-project/flow-framework#990

Setting timeout to 10s for now, as we have not run into problems with the existing manual check done after 1s prior.

This improves the plugin in a few ways:

  • UX state updates as soon as provisioning/reprovisioning is completed
  • UX state has much lower chance of getting out of sync; before, the plugin manually waited a set time and re-fetched the workflow details. Now, it will only fail if provisioning takes > the configured timeout of 10s.

Testing

  • ensured existing flows work as expected, including exercising all changed API paths

Issues Resolved

Makes progress on #571

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler
Copy link
Member Author

Note this DOES NOT need to be included for 2.19 release. We may just backport to 2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant