fix cypress flaky test

Signed-off-by: Adam Tackett <[email protected]>
opensearch-project · Dec 17, 2024 · 6d63fa6 · 6d63fa6
1 parent 1d0a259
commit 6d63fa6
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 33 deletions.
diff --git a/.cypress/integration/trace_analytics_test/trace_analytics_services.spec.js b/.cypress/integration/trace_analytics_test/trace_analytics_services.spec.js
@@ -201,7 +201,7 @@ describe('Testing Service map', () => {
     cy.get('[data-text="Errors"]').click();
     cy.contains('60%');
     cy.get('[data-text="Duration"]').click();
-    cy.contains('100');
+    cy.contains('Average duration (ms)');
 
     // clicks on payment node
     cy.get('.vis-network canvas').click(707, 388);

diff --git a/.cypress/integration/trace_analytics_test/trace_analytics_traces.spec.js b/.cypress/integration/trace_analytics_test/trace_analytics_traces.spec.js
@@ -133,7 +133,7 @@ describe('Testing traces table', () => {
     cy.get('.euiTableCellContent__text').contains('Errors').should('exist');
     cy.get('.euiTableCellContent__text').contains('Last updated').should('exist');
     cy.get('[data-test-subj="pagination-button-next"]').click();
-    cy.contains('client_pay_order').should('exist');
+    cy.contains('HTTP POST').should('exist');
     cy.get('[data-test-subj="pagination-button-previous"]').click();
     cy.contains('224.99').should('exist');
     cy.get('.euiButtonEmpty').contains('5').click();
@@ -144,13 +144,13 @@ describe('Testing traces table', () => {
     cy.go('back');
     cy.get('.euiButtonEmpty__text').contains('Rows per page').click();
     cy.get('.euiContextMenuItem__text').contains('15 rows').click();
-    let expected_row_count=15;
+    let expected_row_count = 15;
     cy.get('.euiTable--auto')
-    .find("tr")
-    .then((row) => {
-      let total=row.length-1;
-      expect(total).to.equal(expected_row_count);
-    });
+      .find("tr")
+      .then((row) => {
+        let total = row.length - 1;
+        expect(total).to.equal(expected_row_count);
+      });
   });
 });
 
@@ -176,27 +176,29 @@ describe('Testing traces tree view', () => {
     //Waiting time for render to complete
     cy.get("[data-test-subj='treeExpandAll']").click();
     cy.get("[data-test-subj='treeCollapseAll']").click();
-
-    cy.get("[data-test-subj='spanId-link']").then((initialSpanIds) => {
-      const initialCount = initialSpanIds.length;
-      expect(initialCount).to.equal(6);
-
-      cy.get("[data-test-subj='treeExpandAll']").click();
-
-      cy.get("[data-test-subj='spanId-link']").then((expandedSpanIds) => {
-        const expandedCount = expandedSpanIds.length;
-        expect(expandedCount).to.equal(10);
-      });
-
-      cy.get("[data-test-subj='treeCollapseAll']").click();
-
-      cy.get("[data-test-subj='spanId-link']").then((collapsedSpanIds) => {
-        const collapsedCount = collapsedSpanIds.length;
-        expect(collapsedCount).to.equal(6); // Collapsed rows should match the initial count
+
+    cy.get("[data-test-subj='spanId-link']")
+      .should('have.length', 6)
+      .then((initialSpanIds) => {
+        const initialCount = initialSpanIds.length;
+        expect(initialCount).to.equal(6);
+
+        cy.get("[data-test-subj='treeExpandAll']").click();
+
+        cy.get("[data-test-subj='spanId-link']").then((expandedSpanIds) => {
+          const expandedCount = expandedSpanIds.length;
+          expect(expandedCount).to.equal(10);
+        });
+
+        cy.get("[data-test-subj='treeCollapseAll']").click();
+
+        cy.get("[data-test-subj='spanId-link']").then((collapsedSpanIds) => {
+          const collapsedCount = collapsedSpanIds.length;
+          expect(collapsedCount).to.equal(6); // Collapsed rows should match the initial count
+        });
       });
-    });
   });
-  
+
   it('Verifies tree view expand arrow functionality', () => {
     cy.get('.euiButtonGroup').contains('Tree view').click();
     cy.contains('Expand all').should('exist');
@@ -208,30 +210,30 @@ describe('Testing traces tree view', () => {
     cy.get("[data-test-subj='spanId-link']").then((initialSpanIds) => {
       const initialCount = initialSpanIds.length;
       expect(initialCount).to.equal(6);
-  
+
       // Find and click the first tree view expand arrow
       cy.get("[data-test-subj='treeViewExpandArrow']").first().click();
-  
+
       // Check the number of Span IDs after expanding the arrow (should be 7)
       cy.get("[data-test-subj='spanId-link']").then((expandedSpanIds) => {
         const expandedCount = expandedSpanIds.length;
         expect(expandedCount).to.equal(7);
       });
     });
   });
-  
+
   it('Verifies span flyout', () => {
     cy.get('.euiButtonGroup').contains('Tree view').click();
     cy.contains('Expand all').should('exist');
     cy.contains("Collapse all").should('exist')
     // Waiting time for render to complete
     cy.get("[data-test-subj='treeExpandAll']").click();
     cy.get("[data-test-subj='treeCollapseAll']").click();
-    
+
     // Open flyout for a span
     cy.get("[data-test-subj='spanId-link']")
-        .contains(SPAN_ID_TREE_VIEW)
-        .click()
+      .contains(SPAN_ID_TREE_VIEW)
+      .click()
     cy.contains('Span detail').should('exist');
     cy.contains('Span attributes').should('exist');
   });