[Cypress Updates] Trace analytics updates #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
|
@ritvibhatt Awesome work! 👍🏽 I see the tests pass, the error in CI is a bug in github actions: |
TackAdam
reviewed
Nov 11, 2024
| cy.contains(' (1)').should('exist'); | ||
| cy.contains('03/25/2021 10:21:22').should('exist'); | ||
| }); | ||
| }); | ||
|
|
||
| //here |
Signed-off-by: Ritvi Bhatt <[email protected]>
TackAdam
approved these changes
Nov 11, 2024
RyanL1997
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Hi @ritvibhatt , thanks for taking this on, and I just left some comments.
| cy.get('.euiContextMenuItem__text').eq(2).contains('Disable all'); | ||
| cy.get('.euiContextMenuItem__text').eq(3).contains('Invert inclusion'); | ||
| cy.get('.euiContextMenuItem__text').eq(4).contains('Invert enabled/disabled'); | ||
| cy.get('.euiContextMenuItem__text').eq(5).contains('Remove all'); |
There was a problem hiding this comment.
Not a blocker, however, I was wondering if we can do something like this:
const menuSelector = '.euiContextMenuItem__text';
const expectedMenuItems = [
'Enable all',
'Disable all',
'Invert inclusion',
'Invert enabled/disabled',
'Remove all',
];
cy.verifyContextMenuItems(menuSelector, expectedMenuItems);There was a problem hiding this comment.
It looks like cypress can do something like that by iterating through each menu item to check but I think it might be more clear to have the order of the menu items laid out so holding off on this for now
.cypress/integration/trace_analytics_test/trace_analytics_services.spec.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Ritvi Bhatt <[email protected]>
RyanL1997
approved these changes
Nov 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
* updated cypress testing for traces Signed-off-by: Ritvi Bhatt <[email protected]> * update snapshots Signed-off-by: Ritvi Bhatt <[email protected]> * wait for page to load before checking rows Signed-off-by: Ritvi Bhatt <[email protected]> * remove forgetten comment Signed-off-by: Ritvi Bhatt <[email protected]> * centralize exapnding service view Signed-off-by: Ritvi Bhatt <[email protected]> --------- Signed-off-by: Ritvi Bhatt <[email protected]> Co-authored-by: Ritvi Bhatt <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 58d58a7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric
pushed a commit
that referenced
this pull request
Nov 12, 2024
* updated cypress testing for traces * update snapshots * wait for page to load before checking rows * remove forgetten comment * centralize exapnding service view --------- (cherry picked from commit 58d58a7) Signed-off-by: Ritvi Bhatt <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ritvi Bhatt <[email protected]> Co-authored-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates trace analytics cypress tests
Issues Resolved
#1886
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.