[Bug] Fix notebook routes for savedNotebook endpoints #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
joshuali925
approved these changes
Dec 6, 2024
Signed-off-by: Shenoy Pratik <[email protected]>
mengweieric
approved these changes
Dec 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Fix notebook routes to remove extra slash Signed-off-by: Shenoy Pratik <[email protected]> * revert legacy notebook api route change Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 4f894de) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Fix notebook routes to remove extra slash * revert legacy notebook api route change --------- (cherry picked from commit 4f894de) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix notebook routes by removing extra slash. This is only done for new endpoints which use savedObjects API, workspaces and MDS.
Issues Resolved
[BUG] notebooks not working with OpenSearch 2.17 (using cognito authentication) #2267
[BUG] Notebook not isolated according to workspace #2262
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.