[Cypress Updates] Fix flaky notebooks test #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 5, 2024 11:43
Signed-off-by: Ritvi Bhatt <[email protected]>
Swiddis
approved these changes
Dec 6, 2024
|
|
||
| cy.get('[data-test-subj="notebook-edit-icon"]').click(); | ||
| cy.get('input.euiFieldText[data-autofocus="true"]').focus().type(' (rename)'); | ||
| cy.get('input.euiFieldText[data-autofocus="true"]').clear().type(TEST_NOTEBOOK + ' (rename)'); |
There was a problem hiding this comment.
suggestion (if-minor): We could consider adding a data-test-subj for this element directly to locate it more reliably
ps48
approved these changes
Dec 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Ritvi Bhatt <[email protected]> Co-authored-by: Ritvi Bhatt <[email protected]> (cherry picked from commit a387358) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit a387358) Signed-off-by: Ritvi Bhatt <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ritvi Bhatt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates notebook renaming test to clear input before typing new name to match up with expected name
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.