Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Bug] Updated notebooks reporting button render #2287

Merged
merged 1 commit into from
Dec 7, 2024
Merged

[Backport 2.x] [Bug] Updated notebooks reporting button render #2287

merged 1 commit into from
Dec 7, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 207004a from #2278.

@github-actions
updated notebooks reporting button render (#2278)
dc1733f 
Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 207004a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ps48 ps48 added the bug Something isn't working label Dec 6, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.20%. Comparing base (3e5ccb0) to head (dc1733f).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ublic/components/notebooks/components/notebook.tsx 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #2287      +/-   ##
==========================================
+ Coverage   56.15%   56.20%   +0.05%     
==========================================
  Files         393      393              
  Lines       15325    15482     +157     
  Branches     4203     4245      +42     
==========================================
+ Hits         8605     8702      +97     
- Misses       6657     6716      +59     
- Partials       63       64       +1
Flag Coverage Δ
dashboards-observability 56.20% <60.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit 64e98ce into 2.x Dec 7, 2024
24 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TackAdam TackAdam TackAdam approved these changes

@ps48 ps48 ps48 approved these changes

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ps48 @TackAdam