Fix (styles): Update border color of Search Relevance to be compliant with Dark Mode #315

nung22 · 2023-10-06T01:55:18Z

Description

Fixes hard-coded horizontal and vertical rules that previously made borders bright white in dark mode. Panels had hasBorder property set to false so that was adjusted, and $ouiBorderColor was used to color the borders instead.

Issues Resolved

Closes #306

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Screenshots

Before

Bright white borders while site is in dark mode:

After

Subtle borders with $ouiBorderColor in dark mode:

Signed-off-by: Nicholas Ung <[email protected]>

sejli

Nice work! Left some small comments to consider

sejli · 2023-10-06T09:44:40Z

...compare/search_result/search_components/__tests__/__snapshots__/search_configs.test.tsx.snap

@@ -372,7 +362,7 @@ exports[`Flyout component Renders flyout component 1`] = `
                          }
                          showPrintMargin={false}
                          tabSize={2}
-                          theme="sql_console"
+                          theme="textmate"


Change to textmate should've been merged in, may need a rebase? Or did this come up only from this PR?

Yeah, I think it needs a rebase. Thanks for catching that, I'll look into it!

sejli · 2023-10-06T09:45:24Z

.../components/query_compare/search_result/search_components/search_configs/search_configs.scss

+  border-right: 0;
+}
+
+.left-border {
+  border-left: 0;
+}


Could this be in a single class?

Yeah, I was actually thinking about putting them in one called "left-right-borders" but wasn't sure if there was a specific naming convention I needed to follow? If that works, I'll make the change.

Signed-off-by: Nicholas Ung <[email protected]>

…search-relevance into fix/issue-306

Signed-off-by: Nicholas Ung <[email protected]>

codecov · 2023-10-06T16:40:04Z

Codecov Report

Merging #315 (4a35b0b) into main (7d062c5) will decrease coverage by 2.88%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
- Coverage   89.95%   87.08%   -2.88%     
==========================================
  Files          16       16              
  Lines         209      209              
  Branches       43       43              
==========================================
- Hits          188      182       -6     
- Misses         20       26       +6     
  Partials        1        1

Flag	Coverage Δ
dashboards-search-relevance	`87.08% <ø> (-2.88%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
public/components/common/header.tsx	`100.00% <ø> (ø)`
...search_components/search_configs/search_config.tsx	`80.00% <ø> (ø)`
...earch_components/search_configs/search_configs.tsx	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

… with Dark Mode (#315) * Update horizontal and vertical rules to comply with Signed-off-by: Nicholas Ung <[email protected]> * Update test snapshots Signed-off-by: Nicholas Ung <[email protected]> * Update horizontal and vertical rules to comply with Signed-off-by: Nicholas Ung <[email protected]> * Update test snapshots Signed-off-by: Nicholas Ung <[email protected]> * Update class name for border Signed-off-by: Nicholas Ung <[email protected]> * Update test snapshots Signed-off-by: Nicholas Ung <[email protected]> --------- Signed-off-by: Nicholas Ung <[email protected]> (cherry picked from commit acb3dd8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

… with Dark Mode (#315) (#319) * Update horizontal and vertical rules to comply with * Update test snapshots * Update horizontal and vertical rules to comply with * Update test snapshots * Update class name for border * Update test snapshots --------- (cherry picked from commit acb3dd8) Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

… with Dark Mode (#315) * Update horizontal and vertical rules to comply with Signed-off-by: Nicholas Ung <[email protected]> * Update test snapshots Signed-off-by: Nicholas Ung <[email protected]> * Update horizontal and vertical rules to comply with Signed-off-by: Nicholas Ung <[email protected]> * Update test snapshots Signed-off-by: Nicholas Ung <[email protected]> * Update class name for border Signed-off-by: Nicholas Ung <[email protected]> * Update test snapshots Signed-off-by: Nicholas Ung <[email protected]> --------- Signed-off-by: Nicholas Ung <[email protected]> (cherry picked from commit acb3dd8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

… with Dark Mode (#315) (#328) * Update horizontal and vertical rules to comply with * Update test snapshots * Update horizontal and vertical rules to comply with * Update test snapshots * Update class name for border * Update test snapshots --------- (cherry picked from commit acb3dd8) Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Update horizontal and vertical rules to comply with

d715233

Signed-off-by: Nicholas Ung <[email protected]>

nung22 requested review from macohen, mingshl, msfroh, noCharger and sejli as code owners October 6, 2023 01:55

Update test snapshots

27b976d

Signed-off-by: Nicholas Ung <[email protected]>

sejli reviewed Oct 6, 2023

View reviewed changes

nung22 added 5 commits October 6, 2023 06:01

Update horizontal and vertical rules to comply with

ef502cb

Signed-off-by: Nicholas Ung <[email protected]>

Update test snapshots

cbb5893

Signed-off-by: Nicholas Ung <[email protected]>

Merge branch 'fix/issue-306' of https://github.com/nung22/dashboards-…

489da94

…search-relevance into fix/issue-306

Update class name for border

cebba09

Signed-off-by: Nicholas Ung <[email protected]>

Update test snapshots

4a35b0b

Signed-off-by: Nicholas Ung <[email protected]>

sejli approved these changes Oct 6, 2023

View reviewed changes

sejli merged commit acb3dd8 into opensearch-project:main Oct 6, 2023
12 checks passed

sejli added the backport 2.x label Oct 6, 2023

github-actions bot mentioned this pull request Oct 6, 2023

[Backport 2.x] Fix (styles): Update border color of Search Relevance to be compliant with Dark Mode #319

Merged

nung22 deleted the fix/issue-306 branch October 7, 2023 01:17

noCharger added the backport 2.11 label Oct 11, 2023

github-actions bot mentioned this pull request Oct 11, 2023

[Backport 2.11] Fix (styles): Update border color of Search Relevance to be compliant with Dark Mode #328

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix (styles): Update border color of Search Relevance to be compliant with Dark Mode #315

Fix (styles): Update border color of Search Relevance to be compliant with Dark Mode #315

nung22 commented Oct 6, 2023

sejli left a comment

sejli Oct 6, 2023

nung22 Oct 6, 2023

sejli Oct 6, 2023

nung22 Oct 6, 2023 •

edited

Loading

codecov bot commented Oct 6, 2023

Fix (styles): Update border color of Search Relevance to be compliant with Dark Mode #315

Fix (styles): Update border color of Search Relevance to be compliant with Dark Mode #315

Conversation

nung22 commented Oct 6, 2023

Description

Issues Resolved

Screenshots

Before

After

sejli left a comment

Choose a reason for hiding this comment

sejli Oct 6, 2023

Choose a reason for hiding this comment

nung22 Oct 6, 2023

Choose a reason for hiding this comment

sejli Oct 6, 2023

Choose a reason for hiding this comment

nung22 Oct 6, 2023 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Oct 6, 2023

Codecov Report

nung22 Oct 6, 2023 •

edited

Loading