[Doc] Update CONTRIBUTING.md by adding DCO section #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Ung <[email protected]>
nung22
requested review from
macohen,
mingshl,
msfroh,
noCharger and
sejli
as code owners
Codecov Report
@@ Coverage Diff @@
## main #337 +/- ##
=======================================
Coverage 87.08% 87.08%
=======================================
Files 16 16
Lines 209 209
Branches 43 43
=======================================
Hits 182 182
Misses 26 26
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. |
sejli
approved these changes
Oct 31, 2023
github-actions bot
added a commit
that referenced
this pull request
Oct 31, 2023
Signed-off-by: Nicholas Ung <[email protected]> (cherry picked from commit 966aed5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
OpenSearch core and dashboard core both have DCO (For example: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Instead of explicitly stating in plugin repositories, I would take them as a reference. cc @macohen |
sejli
pushed a commit
that referenced
this pull request
Nov 3, 2023
(cherry picked from commit 966aed5) Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
CONTRIBUTING.mdfile with more details by adding a section informing contributors about the Developer Certificate of Origin and how to sign off their commits.Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.