Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Bump Cypress version from 5.0.0 to 12.8.1 #296

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

RyanL1997
Copy link
Contributor

Description

Bump Cypress version from 5.0.0 to 12.8.1

The old existed failure on Cypress 5.0.0:

Screenshot 2023-12-13 at 11 10 27 AM

The current failure on Cypress 12.8.1:

Screenshot 2023-12-13 at 11 21 19 AM

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51e3191) 94.73% compared to head (49b3581) 94.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #296   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           5        5           
  Lines         152      152           
  Branches       45       45           
=======================================
  Hits          144      144           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derek-ho derek-ho merged commit 1e13d24 into opensearch-project:main Dec 13, 2023
9 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-visualizations/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-visualizations/backport-2.x
# Create a new branch
git switch --create backport/backport-296-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1e13d24552bfd115d664cb8c3c57d3409cfa1d99
# Push it to GitHub
git push --set-upstream origin backport/backport-296-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-visualizations/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-296-to-2.x.

ps48 pushed a commit to ps48/dashboards-visualizations that referenced this pull request Dec 13, 2023
mengweieric pushed a commit that referenced this pull request Dec 13, 2023
Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 1e13d24)

Co-authored-by: Jialiang Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants