Note that grok ingest processor patterns are not anchored #11182
Conversation
hackery
requested review from
AMoo-Miki,
dlvenable,
epugh,
kolchfa-aws,
natebower and
sumobrian
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
Would it be appropriate to also update the examples to illustrate the recommendation? @kolchfa-aws |
|
@hackery Thanks for this docs addition! Yes, it would be very helpful to include examples if you can. |
|
@gaobinlong Could you review this PR? |
|
@hackery Thanks! Could you fix DCO please? |
|
Oh I see, the DCO check isn't recognising the local Sign-off - sure, will fix. |
Signed-off-by: James Beckett <[email protected]>
Signed-off-by: James Beckett <[email protected]>
hackery
force-pushed
the
ingest-processor-grok-regex-anchoring
branch
from
318a637 to
feac586
Compare
|
@kolchfa-aws do I need to do something else to let this pass checks/approval etc? |
We just need this PR tech reviewed and then we can do a doc/editorial review and merge. |
kolchfa-aws
left a comment
kolchfa-aws
left a comment
There was a problem hiding this comment.
Thanks, @hackery! One suggestion before we can move this forward.
kolchfa-aws
added
Doc review
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Nathan Bower <[email protected]>
* Note that grok ingest processor patterns are not anchored Signed-off-by: James Beckett <[email protected]> * Grok ingest processor: add anchoring to pattern examples Signed-off-by: James Beckett <[email protected]> * Update _ingest-pipelines/processors/grok.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Nathan Bower <[email protected]> --------- Signed-off-by: James Beckett <[email protected]> Signed-off-by: Nathan Bower <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> (cherry picked from commit cbecfc1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
4 participants
Description
Make docs explicit that patterns are not anchored, with advice to do so for performance.
Issues Resolved
None
Version
All
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.