Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec-Insert] Param Table Updates #9076

Merged
merged 13 commits into from
Jan 17, 2025

Conversation

nhtruong
Copy link
Contributor

@nhtruong nhtruong commented Jan 16, 2025

  • Start/End pipes for compact tables
  • Display N/A when no default value is available
  • Display valid values (with descriptions if any) for enums and string constants in Description column.
  • Dynamic default columns selection (Default and Required columns are added when there are values in them)
  • Added ability to alter display texts via a config file.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Signed-off-by: Theo Truong <[email protected]>
spec-insert/config.yml Outdated Show resolved Hide resolved
spec-insert/config.yml Outdated Show resolved Hide resolved
@Naarcha-AWS Naarcha-AWS merged commit f41ef18 into opensearch-project:main Jan 17, 2025
7 checks passed
@nhtruong nhtruong deleted the spec-insert/pipes branch January 17, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants