Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markers for cluster APIs. #9110

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Add markers for cluster APIs. #9110

wants to merge 20 commits into from

Conversation

Naarcha-AWS
Copy link
Collaborator

Part of issue #9050

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@Naarcha-AWS Naarcha-AWS marked this pull request as ready for review February 4, 2025 20:45
@Naarcha-AWS Naarcha-AWS added 4 - Doc review PR: Doc review in progress backport 2.18 PR: Backport label for 2.18 labels Feb 4, 2025
@Naarcha-AWS Naarcha-AWS added backport 2.19 and removed backport 2.18 PR: Backport label for 2.18 labels Feb 12, 2025
@Naarcha-AWS
Copy link
Collaborator Author

Sent two fixes for cluster parameter descriptions:

These must be merged before this PR can move forward.

@Naarcha-AWS Naarcha-AWS removed the 4 - Doc review PR: Doc review in progress label Feb 20, 2025
@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress 4 - Doc review PR: Doc review in progress and removed 5 - Editorial review PR: Editorial review in progress labels Feb 20, 2025
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes to be made in the documentation and in the spec. Thank you.

## Example request

```json
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an endpoint

"zone-3": 1
}
}
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a copy button

@kkhatua
Copy link
Member

kkhatua commented Feb 20, 2025

@Naarcha-AWS would it be possible to have the validation capture this? This almost feels like a checklist is needed... the diffs show the "the default value is ..." translated to "N/A" .
I'm guessing the APISpec should have had this, right? If not, following the process, we'll need to add it as discussed. And for later-planned namespaces, push the onus of this on the Dev teams/

Naarcha-AWS and others added 4 commits February 21, 2025 14:28
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 2.19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants