-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Migration Assistant Type Mapping documentation #9164
base: main
Are you sure you want to change the base?
Add Migration Assistant Type Mapping documentation #9164
Conversation
Signed-off-by: Andre Kurait <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this up.
Lets consider reframing this documentation for a user they doesn't know if they use this deprecated feature, this kind of jumps into 'what to do' without enough context for a user to know if they are impacted and why they should make different choices.
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
@AndreKurait: Let me know once you've implemented @peternied and @mikaylathompson's feedback and I'll begin the writer review process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend two solutions - the first would be to pick up a bit more information from the README file for the transformer.
The second would be to simplify the deployment. Redeploying infrastructure isn't very appealing. Instead, we could
- deploy a new EFS volume (for any deployment configuration) for transformation configurations;
- Add documentation to give the customer a command to add a configuration file (ssm copy, vi /sharedTransformConfigs/...);
- have the container entrypoints check for that config file for type mappings sanitization and just add the arguments;
- Add documentation so to indicate how to run/restart commands
Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
Let me know what additional information you would like me to add here
Tracking this in https://opensearch.atlassian.net/browse/MIGRATIONS-2410 |
Signed-off-by: Andre Kurait <[email protected]>
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Show resolved
Hide resolved
...tion-assistant/migration-phases/planning-your-migration/handling-type-mapping-deprecation.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Andre Kurait <[email protected]>
@Naarcha-AWS Ready for review |
Signed-off-by: Andre Kurait <[email protected]>
Signed-off-by: Andre Kurait <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know there are still some outstanding comment threads around technical implementation, but I think this is a great starting point that we can refine in future releases. Thanks for iterating on this one @AndreKurait
Description
Add Migration Assistant Type Mapping documentation
Issues Resolved
MIGRATIONS-2385
Version
all (Migration Assistant 2.1.5+)
Frontend features
n/a
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.