-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport 2.x] Add synchronous execution option to workflow provisioning(#990) #1009
[backport 2.x] Add synchronous execution option to workflow provisioning(#990) #1009
Conversation
34425a2
to
84ae902
Compare
There's a whole bunch of commits here not part of the backport. :) I like to ignore the instructions on the main pr and do the following:
For now let's try something different.... will wait for integ tests to get fixed and merge the other 2 backports, then toggle the backport label on the main PR and see if it generates properly the next time. |
84ae902
to
ba65765
Compare
…-project#990) * Add synchronous execution option to workflow provisioning Signed-off-by: Junwei Dai <[email protected]> * code refactor Signed-off-by: Junwei Dai <[email protected]> * add change log Signed-off-by: Junwei Dai <[email protected]> * refactor code based on comment Signed-off-by: Junwei Dai <[email protected]> * fix spotless check Signed-off-by: Junwei Dai <[email protected]> * Limit workflow timeout to a range of 1 to 300 seconds Signed-off-by: Junwei Dai <[email protected]> * Limit workflow timeout to a range of 1 to 300 seconds Signed-off-by: Junwei Dai <[email protected]> * Limit workflow timeout to non-negative Signed-off-by: Junwei Dai <[email protected]> * Add synchronous execution to reprovision Signed-off-by: Junwei Dai <[email protected]> * remove unsued common value Signed-off-by: Junwei Dai <[email protected]> * add reprovision sync execution Signed-off-by: Junwei Dai <[email protected]> * fix test for WorkflowTimeoutUtilityTests Signed-off-by: Junwei Dai <[email protected]> * fix test name for WorkflowTimeoutUtilityTests Signed-off-by: Junwei Dai <[email protected]> * Add comments to explain AtomicBoolean usage in WorkflowTimeoutUtility, update error message Signed-off-by: Junwei Dai <[email protected]> * fix spotless check Signed-off-by: Junwei Dai <[email protected]> * addressed some comments Signed-off-by: Junwei Dai <[email protected]> --------- Signed-off-by: Junwei Dai <[email protected]> Co-authored-by: Junwei Dai <[email protected]>
ba65765
to
e362da2
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-1009-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8d4550dbd233f1f1d0ddd07c864a3127f2575fad
# Push it to GitHub
git push --set-upstream origin backport/backport-1009-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x Then, create a pull request where the |
Description
Manually backport #990 to 2.x
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.