-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch diffCoverage plugin to deltaCoverage #762
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
=========================================
Coverage 74.37% 74.37%
Complexity 745 745
=========================================
Files 84 84
Lines 3825 3825
Branches 333 333
=========================================
Hits 2845 2845
Misses 825 825
Partials 155 155 ☔ View full report in Codecov by Sentry. |
Mend security failing here |
It's been flaky for the past several days across multiple repos... something about its token. Retrying usually works. |
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Is this something we are changing in core as well? We were using |
That's codecov that you're thinking of. That won't change, we'll still get the PR comments with the coverage diff, see #763 (comment) This is a local command you can type, that's only implemented in our plugin and the Extensions SDK, that the maintainer abandoned, and which doesn't support JDK21. Someone's moved forward with a fork of that. So I can locally run The details match CodeCov exactly. |
* Switch diffCoverage plugin to deltaCoverage Signed-off-by: Daniel Widdis <[email protected]> * Allow lower NodeJS version on GH runners for security test Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit a0a9375) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Switch diffCoverage plugin to deltaCoverage Signed-off-by: Daniel Widdis <[email protected]> * Allow lower NodeJS version on GH runners for security test Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit a0a9375) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Switch diffCoverage plugin to deltaCoverage (#762) * Switch diffCoverage plugin to deltaCoverage Signed-off-by: Daniel Widdis <[email protected]> * Allow lower NodeJS version on GH runners for security test Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit a0a9375) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update build.gradle Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Widdis <[email protected]>
Description
Removes the abandonware diffCoverage plugin and replaces it with deltaCoverage.
Issues Resolved
Fixes #761
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.