feat(chart/opensearch): add ability for serviceMonitor basicauth #594
Conversation
eyenx
requested review from
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
|
Note: We are in the review of an older PR now so will come back to this a little later. |
|
@peterzhuamazon any update here? Thanks! |
|
@peterzhuamazon any update here? |
charts/opensearch/values.yaml
Outdated
| # password: | ||
| # secretName: credentials | ||
| # secretKey: password | ||
| basicAuth: {} |
There was a problem hiding this comment.
Thanks @eyenx can you please some details in the README ? also can basicAuth have one secret with username and password ?
There was a problem hiding this comment.
I will take a look at it tomorrow
There was a problem hiding this comment.
I now added a existingSecret functionality and a way to deliver the username & pw over the helm charts values
eyenx
force-pushed
the
feat/serviceMonitor-with-basic-auth
branch
from
c4b5ba0 to
f3a06ee
Compare
|
Hi @TheAlgo @prudhvigodithi please take another pass before I give an approval. Thanks. |
|
Pinging @prudhvigodithi @TheAlgo again to co-review. Thanks! |
eyenx
force-pushed
the
feat/serviceMonitor-with-basic-auth
branch
from
f3a06ee to
9d239a8
Compare
|
@prudhvigodithi @TheAlgo @peterzhuamazon Another attempt at getting this merged! Please review! Thank you! |
|
I would also be very happy to backport this to version |
|
Adding @TheAlgo @prudhvigodithi @DandyDeveloper @gaiksaya to take a look. Thanks! |
|
Hi Team, When we can expect a 1.3.x version of this changes (#593 as well)? Thanks, |
|
As soon as this gets merged I will backport it. |
|
Will rebase today |
Signed-off-by: Toni Tauro <[email protected]>
Signed-off-by: Toni Tauro <[email protected]>
Signed-off-by: Toni Tauro <[email protected]>
eyenx
force-pushed
the
feat/serviceMonitor-with-basic-auth
branch
from
9d239a8 to
5dd0ace
Compare
|
Ready for Review @TheAlgo @DandyDeveloper @gaiksaya @prudhvigodithi |
Signed-off-by: Toni Tauro <[email protected]>
Signed-off-by: Toni Tauro <[email protected]>
Signed-off-by: Toni Tauro <[email protected]>
Thanks much @eyenx !! |
| @@ -128,6 +128,10 @@ helm uninstall my-release | |||
| | `serviceMonitor.enabled` | Enables the creation of a [ServiceMonitor] resource for Prometheus monitoring. Requires the Prometheus Operator to be installed in your Kubernetes cluster. | `false` | | |||
| | `serviceMonitor.path` | Path where metrics are exposed. Applicable only if `serviceMonitor.enabled` is set to `true`. | `/_prometheus/metrics` | | |||
| | `serviceMonitor.interval` | Interval at which metrics should be scraped by Prometheus. Applicable only if `serviceMonitor.enabled` is set to `true`. | `10s` | | |||
| | `serviceMonitor.basicAuth.enabled` | Wheter or not the serviceMonitor should use basic auth | `false` | | |||
| | `serviceMonitor.basicAuth.existingSecret` | When using basicAuth for the serviceMonitory, use an existing secret | `""` | | |||
There was a problem hiding this comment.
Is serviceMonitory typo?
There was a problem hiding this comment.
Hey @eyenx please take a look, we can get this merged.
Thanks
|
Thanks @eyenx we can get this merged. |
Description
Right now there is non possibility to set a
basicAuthconfiguration for theserviceMonitor. This PR adds itCheck List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.