fix(chart/data-prepper) Remove demo pipeline from values, add explicit demo value #634
+70
−158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR comments demo pipline from values, and also removes the alread-commented complex pipeline example, refering to documentation instead.
Now, when installing the chart with defaults only, the install will fail with this message:
If you instead install the chart with
--set pipelineConfig.demoPipeline=true
, the behavior will be identical to current chart behavior, and we also print an informative message in stdout about what pipeline configuration is in use:Issues Resolved
Fixes #624
Check List
For any changes to files within Helm chart directories:
CHANGELOG.md
updated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.