Fixed Backport section in developer guide #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaptainDredge
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
Signed-off-by: Prabhat Sharma <[email protected]>
CaptainDredge
force-pushed
the
backport-doc-fix
branch
from
5c1aaae to
d60159c
Compare
r1walz
approved these changes
Apr 29, 2024
|
@r1walz @vikasvb90 why did we merge this commit, when unit tests were failing ? |
|
@RamakrishnaChilaka I haven't approved or merged this. Also, I don't see any code change in this PR so failing tests must be from a different commit. For documentation PRs we can probably skip the mandate but for PRs having code or other script changes, we should have a green build for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the non existing backport file reference and adds latest guidelines for backporting. This will resolve the failing lint checks in existing CIs
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.