bug fix: Snapshot restore always restores index alias #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skumawat2025
requested review from
bowenlan-amzn,
Hailong-am,
RamakrishnaChilaka,
vikasvb90 and
SuZhou-Joe
as code owners
ltaragi
reviewed
Nov 13, 2024
public/pages/Snapshots/components/RestoreSnapshotFlyout/RestoreSnapshotFlyout.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025
force-pushed
the
snp-bug-fix
branch
from
3d0af26 to
f54b40d
Compare
|
LGTM |
ltaragi
approved these changes
Nov 13, 2024
RamakrishnaChilaka
approved these changes
Nov 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> (cherry picked from commit bb075f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RamakrishnaChilaka
added a commit
that referenced
this pull request
Dec 16, 2024
(cherry picked from commit bb075f6) Signed-off-by: Sandeep Kumawat <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: Ramakrishna Chilaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is follow up PR #1193 for fixing the bug in snapshot restore page. Currently snapshot restore always restores index alias.
In this PR we set default value to
truefor include_aliases parameter as mentioned in the documentation: https://opensearch.org/docs/latest/api-reference/snapshots/restore-snapshot/#request-body-fields which we changed in the previous PR by mistake.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.