Switch type of expandNested from boolean to Boolean (#2333)

Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit aa6936a)
opensearch-project · Dec 14, 2024 · 4122f60 · 4122f60
1 parent 1aa6bee
commit 4122f60
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 10 deletions.
diff --git a/src/main/java/org/opensearch/knn/index/query/BaseQueryFactory.java b/src/main/java/org/opensearch/knn/index/query/BaseQueryFactory.java
@@ -50,7 +50,7 @@ public static class CreateQueryRequest {
         private QueryBuilder filter;
         private QueryShardContext context;
         private RescoreContext rescoreContext;
-        private boolean expandNested;
+        private Boolean expandNested;
 
         public Optional<QueryBuilder> getFilter() {
             return Optional.ofNullable(filter);
@@ -63,6 +63,10 @@ public Optional<QueryShardContext> getContext() {
         public Optional<RescoreContext> getRescoreContext() {
             return Optional.ofNullable(rescoreContext);
         }
+
+        public Optional<Boolean> getExpandNested() {
+            return Optional.ofNullable(expandNested);
+        }
     }
 
     /**

diff --git a/src/main/java/org/opensearch/knn/index/query/KNNQueryBuilder.java b/src/main/java/org/opensearch/knn/index/query/KNNQueryBuilder.java
@@ -109,7 +109,7 @@ public class KNNQueryBuilder extends AbstractQueryBuilder<KNNQueryBuilder> {
     @Getter
     private RescoreContext rescoreContext;
     @Getter
-    private boolean expandNested;
+    private Boolean expandNested;
 
     /**
      * Constructs a new query with the given field name and vector
@@ -151,7 +151,7 @@ public static class Builder {
         private String queryName;
         private float boost = DEFAULT_BOOST;
         private RescoreContext rescoreContext;
-        private boolean expandNested;
+        private Boolean expandNested;
 
         public Builder() {}
 
@@ -210,7 +210,7 @@ public Builder rescoreContext(RescoreContext rescoreContext) {
             return this;
         }
 
-        public Builder expandNested(boolean expandNested) {
+        public Builder expandNested(Boolean expandNested) {
             this.expandNested = expandNested;
             return this;
         }
@@ -330,7 +330,7 @@ public KNNQueryBuilder(String fieldName, float[] vector, int k, QueryBuilder fil
         this.maxDistance = null;
         this.minScore = null;
         this.rescoreContext = null;
-        this.expandNested = false;
+        this.expandNested = null;
     }
 
     public static void initialize(ModelDao modelDao) {

diff --git a/src/main/java/org/opensearch/knn/index/query/KNNQueryFactory.java b/src/main/java/org/opensearch/knn/index/query/KNNQueryFactory.java
@@ -51,7 +51,7 @@ public static Query create(CreateQueryRequest createQueryRequest) {
         final Map<String, ?> methodParameters = createQueryRequest.getMethodParameters();
         final RescoreContext rescoreContext = createQueryRequest.getRescoreContext().orElse(null);
         final KNNEngine knnEngine = createQueryRequest.getKnnEngine();
-        final boolean expandNested = createQueryRequest.isExpandNested();
+        final boolean expandNested = createQueryRequest.getExpandNested().orElse(false);
         BitSetProducer parentFilter = null;
         if (createQueryRequest.getContext().isPresent()) {
             QueryShardContext context = createQueryRequest.getContext().get();

diff --git a/src/main/java/org/opensearch/knn/index/query/parser/KNNQueryBuilderParser.java b/src/main/java/org/opensearch/knn/index/query/parser/KNNQueryBuilderParser.java
@@ -136,7 +136,7 @@ public static KNNQueryBuilder.Builder streamInput(StreamInput in, Function<Strin
         }
 
         if (minClusterVersionCheck.apply(EXPAND_NESTED)) {
-            builder.expandNested(in.readBoolean());
+            builder.expandNested(in.readOptionalBoolean());
         }
 
         return builder;
@@ -176,7 +176,7 @@ public static void streamOutput(StreamOutput out, KNNQueryBuilder builder, Funct
             RescoreParser.streamOutput(out, builder.getRescoreContext());
         }
         if (minClusterVersionCheck.apply(EXPAND_NESTED)) {
-            out.writeBoolean(builder.isExpandNested());
+            out.writeOptionalBoolean(builder.getExpandNested());
         }
     }
 
@@ -252,8 +252,8 @@ public static void toXContent(XContentBuilder builder, ToXContent.Params params,
         if (knnQueryBuilder.queryName() != null) {
             builder.field(NAME_FIELD.getPreferredName(), knnQueryBuilder.queryName());
         }
-        if (knnQueryBuilder.isExpandNested()) {
-            builder.field(EXPAND_NESTED, knnQueryBuilder.isExpandNested());
+        if (knnQueryBuilder.getExpandNested() != null) {
+            builder.field(EXPAND_NESTED, knnQueryBuilder.getExpandNested());
         }
 
         builder.endObject();