[Backport 2.x] Add parent join support for lucene knn #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
|
Pending for opensearch-project/OpenSearch#10360 |
heemin32
force-pushed
the
backport/backport-1182-to-2.x
branch
from
e366ffd to
288f120
Compare
|
Pending #1211 |
Call DiversifyingChildren[Byte|Float]KnnVectorQuery for nested field so that k number of parent document can be returned in search result Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit a496926)
heemin32
force-pushed
the
backport/backport-1182-to-2.x
branch
from
288f120 to
b7539b9
Compare
heemin32
approved these changes
Nov 7, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1230 +/- ##
============================================
+ Coverage 85.12% 85.16% +0.04%
- Complexity 1187 1188 +1
============================================
Files 155 155
Lines 4881 4875 -6
Branches 450 451 +1
============================================
- Hits 4155 4152 -3
+ Misses 530 527 -3
Partials 196 196
|
junqiu-lei
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a496926 from #1182