[Manually backport 2.x] Allow nested knn field mapping when train model #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit 2e3ab95) Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
martin-gaievski
as code owners
junqiu-lei
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1339 +/- ##
============================================
- Coverage 85.17% 85.13% -0.05%
- Complexity 1188 1194 +6
============================================
Files 155 155
Lines 4876 4903 +27
Branches 451 459 +8
============================================
+ Hits 4153 4174 +21
- Misses 527 531 +4
- Partials 196 198 +2 ☔ View full report in Codecov by Sentry. |
navneet1v
approved these changes
Dec 7, 2023
VijayanB
approved these changes
Dec 7, 2023
ryanbogan
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually backport #1318 into 2.x branch to replace failed auto backport PR #1338
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.