-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky tests #1355
Fix flaky tests #1355
Conversation
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
============================================
+ Coverage 85.08% 85.10% +0.01%
- Complexity 1242 1251 +9
============================================
Files 161 162 +1
Lines 5069 5101 +32
Branches 473 477 +4
============================================
+ Hits 4313 4341 +28
- Misses 551 554 +3
- Partials 205 206 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
qa/restart-upgrade/src/test/java/org/opensearch/knn/bwc/ModelIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/knn/plugin/transport/GetModelResponseTests.java
Outdated
Show resolved
Hide resolved
qa/restart-upgrade/src/test/java/org/opensearch/knn/bwc/ModelIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <[email protected]>
src/test/java/org/opensearch/knn/plugin/transport/GetModelResponseTests.java
Outdated
Show resolved
Hide resolved
qa/restart-upgrade/src/test/java/org/opensearch/knn/bwc/ModelIT.java
Outdated
Show resolved
Hide resolved
qa/restart-upgrade/src/test/java/org/opensearch/knn/bwc/ModelIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
@ryanbogan - I assume we need this change in 2.x too? |
Yeah, this should be backported |
391a2ef
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1355-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 391a2ef7de94ddb6d4ad2d67829c8ef29599016d
# Push it to GitHub
git push --set-upstream origin backport/backport-1355-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Nice, wasn't sure that you have permissions to add PR labels |
Description
Fixes the flaky tests on k-NN
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.