Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Optimize Faiss Query With Filters: Reduce iteration and memory for id filter #1504

Merged
merged 1 commit into from
Mar 4, 2024

Optimize Faiss Query With Filters: Reduce iteration and memory for id…

4ebb39a
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.x] Optimize Faiss Query With Filters: Reduce iteration and memory for id filter #1504

Optimize Faiss Query With Filters: Reduce iteration and memory for id…
4ebb39a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 4, 2024 in 0s

85.16% (target 70.00%)

View this Pull Request on Codecov

85.16% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 94.11765% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.16%. Comparing base (513e496) to head (4ebb39a).

Files Patch % Lines
...java/org/opensearch/knn/index/query/KNNWeight.java 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1504      +/-   ##
============================================
+ Coverage     85.05%   85.16%   +0.11%     
- Complexity     1256     1258       +2     
============================================
  Files           162      163       +1     
  Lines          5152     5177      +25     
  Branches        495      497       +2     
============================================
+ Hits           4382     4409      +27     
+ Misses          563      560       -3     
- Partials        207      208       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.