Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select index settings based on cluster version #2236

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

VijayanB
Copy link
Member

@VijayanB VijayanB commented Oct 24, 2024

Description

With #2229 , starting 2.18 no graphs will be built if number of document is less than 15K by using default knn index settings. Hence, select index settings based on cluster version, where starting 2.18 it will have "index.knn.advancend.approximate_threshold" set to 0, and uses old defaults for any other cluster that are before 2.18.

Related Issues

#1942

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@VijayanB VijayanB marked this pull request as draft October 24, 2024 21:58
@VijayanB VijayanB changed the title Update bwc test to update index setting select index settings based on cluster version Oct 24, 2024
@VijayanB VijayanB changed the title select index settings based on cluster version Select index settings based on cluster version Oct 24, 2024
Signed-off-by: Vijayan Balasubramanian <[email protected]>
@VijayanB VijayanB marked this pull request as ready for review October 24, 2024 23:52
@VijayanB VijayanB mentioned this pull request Oct 24, 2024
5 tasks
@VijayanB VijayanB self-assigned this Oct 25, 2024
@VijayanB VijayanB merged commit cbf90f5 into opensearch-project:main Oct 25, 2024
36 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2236-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cbf90f5a456108fa49ffb85020f3edf7e307420e
# Push it to GitHub
git push --set-upstream origin backport/backport-2236-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2236-to-2.x.

VijayanB added a commit to VijayanB/k-NN-2 that referenced this pull request Oct 25, 2024
VijayanB added a commit to VijayanB/k-NN-2 that referenced this pull request Oct 25, 2024
VijayanB added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants