-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select index settings based on cluster version #2236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
requested review from
heemin32,
navneet1v,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
October 24, 2024 21:58
VijayanB
changed the title
Update bwc test to update index setting
select index settings based on cluster version
Oct 24, 2024
VijayanB
changed the title
select index settings based on cluster version
Select index settings based on cluster version
Oct 24, 2024
Signed-off-by: Vijayan Balasubramanian <[email protected]>
5 tasks
naveentatikonda
approved these changes
Oct 24, 2024
junqiu-lei
approved these changes
Oct 25, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2236-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cbf90f5a456108fa49ffb85020f3edf7e307420e
# Push it to GitHub
git push --set-upstream origin backport/backport-2236-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
VijayanB
added a commit
to VijayanB/k-NN-2
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
added a commit
to VijayanB/k-NN-2
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
added a commit
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #2229 , starting 2.18 no graphs will be built if number of document is less than 15K by using default knn index settings. Hence, select index settings based on cluster version, where starting 2.18 it will have "index.knn.advancend.approximate_threshold" set to 0, and uses old defaults for any other cluster that are before 2.18.
Related Issues
#1942
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.