Added null checks for fieldInfo in ExactSearcher to avoid NPE while running exact search for segments with no vector field #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
force-pushed
the
main
branch
4 times, most recently
from
0fd48b2 to
ea65786
Compare
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
navneet1v
force-pushed
the
main
branch
4 times, most recently
from
dade02b to
ffd90fc
Compare
navneet1v
added
Bug Fixes
Vikasht34
reviewed
Nov 18, 2024
src/main/java/org/opensearch/knn/index/query/ExactSearcher.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/ExactSearcher.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/query/nativelib/NativeEngineKnnVectorQuery.java
Outdated
Show resolved
Hide resolved
shatejas
reviewed
Nov 18, 2024
src/main/java/org/opensearch/knn/index/query/nativelib/NativeEngineKnnVectorQuery.java
Outdated
Show resolved
Hide resolved
navneet1v
force-pushed
the
main
branch
2 times, most recently
from
2b6a3b1 to
6b758f6
Compare
shatejas
previously approved these changes
Nov 19, 2024
seems to be related to new dependency upgrades. Will check |
shatejas
previously approved these changes
Nov 19, 2024
navneet1v
changed the title
navneet1v
force-pushed
the
main
branch
2 times, most recently
from
ddc5ffd to
33f05a5
Compare
shatejas
previously approved these changes
Nov 20, 2024
src/test/java/org/opensearch/knn/index/query/ExactSearcherTests.java
Outdated
Show resolved
Hide resolved
Vikasht34
approved these changes
Nov 20, 2024
…unning exact search for segments with no vector field Signed-off-by: Navneet Verma <[email protected]>
|
@heemin32 , @jmazanec15 and @shatejas can you guys review this PR. |
heemin32
approved these changes
Nov 21, 2024
shatejas
approved these changes
Nov 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
…unning exact search for segments with no vector field (#2278) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 7523cc3)
navneet1v
added a commit
that referenced
this pull request
Nov 22, 2024
…unning exact search for segments with no vector field (#2278) (#2285) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 7523cc3) Co-authored-by: Navneet Verma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added null checks for fieldInfo in ExactSearcher to avoid NPE while running exact search for segments with no vector field
Ensured that in ExactSearcher class, if fieldInfo is null for a field no results are returned. This is similar to what we have to ANNSearch ref: https://github.com/opensearch-project/k-NN/blob/main/src/main/java/org/opensearch/knn/index/query/KNNWeight.java#L232-L236.
Related Issues
Resolves #2277
Check List
New functionality has been documented.API changes companion pull request created.--signoff.Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.