-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update knn index default to always do approximate search in test #2332
Update knn index default to always do approximate search in test #2332
Conversation
cf1deca
to
5701675
Compare
There might be test cases which use custom setting instead of default setting. We need to update those cases as well. |
like what? Can you share the test that you are referring to? |
Signed-off-by: Vijayan Balasubramanian <[email protected]>
Signed-off-by: Vijayan Balasubramanian <[email protected]>
850ddba
to
691810a
Compare
Signed-off-by: Vijayan Balasubramanian <[email protected]>
Settings settings = Settings.builder() | ||
.put("index.knn", true) | ||
.put(KNNSettings.KNN_ALGO_PARAM_EF_SEARCH, 512) | ||
.put(KNNSettings.INDEX_KNN_ADVANCED_APPROXIMATE_THRESHOLD, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for cases like this I think we should just move the code to use getDefaultIndexSettings
so that in future we don't need to make the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Just 1 minor comment
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2332-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dc369e6d73beb068c4203db9f9375a6194d824f8
# Push it to GitHub
git push --set-upstream origin backport/backport-2332-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…nsearch-project#2332) * Update knn index default to always do approximate search Signed-off-by: Vijayan Balasubramanian <[email protected]> * Update custom mappings Signed-off-by: Vijayan Balasubramanian <[email protected]> * update bwc Signed-off-by: Vijayan Balasubramanian <[email protected]> --------- Signed-off-by: Vijayan Balasubramanian <[email protected]>
…nsearch-project#2332) * Update knn index default to always do approximate search Signed-off-by: Vijayan Balasubramanian <[email protected]> * Update custom mappings Signed-off-by: Vijayan Balasubramanian <[email protected]> * update bwc Signed-off-by: Vijayan Balasubramanian <[email protected]> --------- Signed-off-by: Vijayan Balasubramanian <[email protected]>
…) (#2350) * Update knn index default to always do approximate search * Update custom mappings * update bwc --------- Signed-off-by: Vijayan Balasubramanian <[email protected]>
Description
Update knn index default to always do approximate search in test cases
Related Issues
Resolves #2329
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.