Support new page header #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 80.29% 83.81% +3.52%
==========================================
Files 26 43 +17
Lines 477 686 +209
Branches 109 151 +42
==========================================
+ Hits 383 575 +192
- Misses 67 80 +13
- Partials 27 31 +4 ☔ View full report in Codecov by Sentry. |
ruanyl
approved these changes
Aug 19, 2024
raintygao
approved these changes
Aug 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Support new page header Signed-off-by: Lin Wang <[email protected]> * Updatenew home page title text Signed-off-by: Lin Wang <[email protected]> * Fix unit tests for page header Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 63326ee)
wanglam
added a commit
that referenced
this pull request
Aug 19, 2024
* Support new page header Signed-off-by: Lin Wang <[email protected]> * Updatenew home page title text Signed-off-by: Lin Wang <[email protected]> * Fix unit tests for page header Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 63326ee) Co-authored-by: Lin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for supporting new page header. It mainly includes below changes:
Screenshots
New home enabled
New home disabled
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.