Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align font size and style #355

Merged

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Aug 30, 2024

Description

  • Using small text for flyout header title
    image

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@wanglam wanglam marked this pull request as ready for review August 30, 2024 10:20
@@ -114,7 +114,7 @@ export const PreviewPanel = ({ onClose, model, dataSourceId }: Props) => {
return (
<EuiFlyout onClose={onCloseFlyout}>
<EuiFlyoutHeader hasBorder>
<EuiTitle size="m">
<EuiTitle size="s">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be <EuiText size="s"> instead of <EuiTitle size="s">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this looks good!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will update this. Thanks.

@wanglam wanglam changed the title Update flyout header using small text Align font size and style Sep 3, 2024
@wanglam wanglam merged commit 0129b13 into opensearch-project:main Sep 3, 2024
5 of 6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
* Update flyout header using small text

Signed-off-by: Lin Wang <[email protected]>

* Use small size for empty prompt body

Signed-off-by: Lin Wang <[email protected]>

* Update EuiTitle to EuiText

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 0129b13)
wanglam added a commit that referenced this pull request Sep 4, 2024
* Update flyout header using small text

Signed-off-by: Lin Wang <[email protected]>

* Use small size for empty prompt body

Signed-off-by: Lin Wang <[email protected]>

* Update EuiTitle to EuiText

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 0129b13)

Co-authored-by: Lin Wang <[email protected]>
opensearch-trigger-bot bot added a commit that referenced this pull request Sep 5, 2024
* Update flyout header using small text

Signed-off-by: Lin Wang <[email protected]>

* Use small size for empty prompt body

Signed-off-by: Lin Wang <[email protected]>

* Update EuiTitle to EuiText

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 0129b13)

Co-authored-by: Lin Wang <[email protected]>
(cherry picked from commit e39ff32)
wanglam pushed a commit that referenced this pull request Sep 5, 2024
* Update flyout header using small text

Signed-off-by: Lin Wang <[email protected]>

* Use small size for empty prompt body

Signed-off-by: Lin Wang <[email protected]>

* Update EuiTitle to EuiText

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 0129b13)

Co-authored-by: Lin Wang <[email protected]>
(cherry picked from commit e39ff32)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants