Reduce machine learning table spacing when new home page enabled #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
ruanyl
reviewed
Sep 27, 2024
| intervalId = window.setInterval(() => { | ||
| onRefresh(); | ||
| }, interval); | ||
| }, Math.min(interval, 2147483647)); |
There was a problem hiding this comment.
Better to give it a name: MAX_SIGNED_32_BIT_INTEGER
Signed-off-by: Lin Wang <[email protected]>
ruanyl
approved these changes
Sep 27, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
* Reduce machine learning table spacing Signed-off-by: Lin Wang <[email protected]> * Fix input overflow in new home page enabled Signed-off-by: Lin Wang <[email protected]> * Avoid refresh immediately after very large number input Signed-off-by: Lin Wang <[email protected]> * Addre PR comments Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 801bb59)
wanglam
added a commit
that referenced
this pull request
Sep 27, 2024
… (#381) * Reduce machine learning table spacing Signed-off-by: Lin Wang <[email protected]> * Fix input overflow in new home page enabled Signed-off-by: Lin Wang <[email protected]> * Avoid refresh immediately after very large number input Signed-off-by: Lin Wang <[email protected]> * Addre PR comments Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 801bb59) Co-authored-by: Lin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for reducing spacing in AI models table when new home page enabled, mainly include below updates:
RefreshIntervalavoid input overflowThis PR also include one bug fixing for refresh with a very large number. The refresh API will be called many times after input a very large delay number.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.