Skip to content

Conversation

ylwu-amzn
Copy link
Collaborator

@ylwu-amzn ylwu-amzn commented Oct 13, 2025

Description

Test langgraph with Agentic Memory, see some issues

  1. Working memory doesn't have checkpoint id field. Can save it to structured data but we can't sort by it because structured data is flat object.
  2. Memory added, but not searchable immediately. That cause checkpoint becomes messy in a conversation. Need to add refresh policy.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.14%. Comparing base (2d85f10) to head (dce9c8c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rch/ml/common/memorycontainer/MLWorkingMemory.java 0.00% 9 Missing ⚠️
...ort/memorycontainer/memory/MLAddMemoriesInput.java 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4305      +/-   ##
============================================
- Coverage     80.16%   80.14%   -0.03%     
  Complexity    10175    10175              
============================================
  Files           854      854              
  Lines         44206    44231      +25     
  Branches       5115     5117       +2     
============================================
+ Hits          35437    35448      +11     
- Misses         6620     6632      +12     
- Partials       2149     2151       +2     
Flag Coverage Δ
ml-commons 80.14% <56.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 13, 2025 04:28 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 13, 2025 04:28 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 13, 2025 05:56 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit 709ba4b into opensearch-project:main Oct 13, 2025
20 of 23 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 13, 2025
Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 709ba4b)
ylwu-amzn added a commit that referenced this pull request Oct 13, 2025
(cherry picked from commit 709ba4b)

Signed-off-by: Yaliang Wu <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants