[Backport 2.x] Enhance: Add comments to chunking-related code #1115
+90
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* add logs for chunker parameter parser Signed-off-by: yuye-aws <[email protected]> * add logs for delimiter chunker Signed-off-by: yuye-aws <[email protected]> * add comments for delimiter chunker Signed-off-by: yuye-aws <[email protected]> * update comments for delimiter chunker Signed-off-by: yuye-aws <[email protected]> * update comments for chunker interface Signed-off-by: yuye-aws <[email protected]> * add comments for chunker facdtory Signed-off-by: yuye-aws <[email protected]> * update comments for chunker interface Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> (cherry picked from commit 3130de3)
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
vibrantvarun
approved these changes
Jan 16, 2025
zhichao-aws
approved these changes
Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1115 +/- ##
=========================================
Coverage 80.42% 80.42%
Complexity 1210 1210
=========================================
Files 93 93
Lines 4154 4154
Branches 699 699
=========================================
Hits 3341 3341
Misses 543 543
Partials 270 270 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3130de3 from #1106