Add few fixes to minimize stack resource changes #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Divya Madala <[email protected]>
Divyaasm
requested review from
peterzhuamazon,
gaiksaya,
rishabh6788,
zelinh and
prudhvigodithi
as code owners
peterzhuamazon
approved these changes
Jan 28, 2025
gaiksaya
requested changes
Jan 29, 2025
| @@ -96,6 +96,7 @@ export class CIStack extends Stack { | |||
|
|
|||
| const auditloggingS3Bucket = new CiAuditLogging(this); | |||
| const vpc = new Vpc(this, 'JenkinsVPC', { | |||
| availabilityZones: ['us-east-1a', 'us-east-1b', 'us-east-1c'], | |||
There was a problem hiding this comment.
This should be dynamic. I always use this repo to deploy in us-west-2. In that case, the deployment would fail. Either take this as context parameters or keep whatever is default.
There was a problem hiding this comment.
Without this change VPC is getting recreated. Hardcodes as both prod and beta deploy in us-east-1. Passing the values thorough context parameter can be implemented.
There was a problem hiding this comment.
Yeah that is just for https://build.ci.opensearch.org/. Take into consideration for users deploying in their own dev environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specifying availiability zones to avoid vpc re-creation
using -p to avoid folder already /var/lib/jenkins exists error! when dataRetention parameter is set to true
Issues Resolved
#517
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.