Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport main] [Security Analytics] Add force type option to avoid element getting covered error #1104

Merged
merged 1 commit into from
May 9, 2024
Merged

[Backport main] [Security Analytics] Add force type option to avoid element getting covered error #1104

merged 1 commit into from
May 9, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport eb10f07 from #1102

@SuZhou-Joe
Copy link
Member

Security analytics related test failed, in #1102 the CI failed either, could you please take a look? @amsiglan

@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-1102-to-main branch from 3cf3897 to ba632f4 Compare February 26, 2024 09:33
@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-1102-to-main branch from 9c2fc68 to a2931f5 Compare March 20, 2024 23:02
@amsiglan @SuZhou-Joe
[Security analytics] add force option to avoid element getting covere…
001a20f 
…d error (#1102)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit eb10f07)
@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-1102-to-main branch from a2931f5 to 001a20f Compare May 8, 2024 06:03
SuZhou-Joe
SuZhou-Joe requested changes May 8, 2024
View reviewed changes
Copy link
Member

@SuZhou-Joe SuZhou-Joe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the test cases failed, please address them before merging.

@amsiglan amsiglan mentioned this pull request May 9, 2024
Open
@amsiglan
Copy link
Contributor

amsiglan commented May 9, 2024

Created issue #1310 to investigate CI failures

@SuZhou-Joe SuZhou-Joe merged commit 1348ec1 into main May 9, 2024
36 of 41 checks passed
@github-actions github-actions bot deleted the backport/backport-1102-to-main branch May 9, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@kavilla kavilla kavilla approved these changes

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuZhou-Joe @amsiglan @kavilla