Add tests for workspace deletion #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
raintygao
reviewed
Nov 8, 2024
| describe('delete a workspace successfully using action buttons', () => { | ||
| it('should successfully load delete button and show delete modal when clicking action button', () => { | ||
| cy.contains(workspace1Name).should('be.visible'); | ||
| cy.getElementByTestId('euiCollapsedItemActionsButton').first().click(); |
There was a problem hiding this comment.
Is there any other way to find this button?
There was a problem hiding this comment.
can we use cy.getElementByTestId(`checkboxSelectRow-${workspaceId}`)
There was a problem hiding this comment.
Thank you for all the comments, updated.
Hailong-am
approved these changes
Nov 8, 2024
| cy.createWorkspace({ | ||
| name: workspace1Name, | ||
| description: workspace1Description, | ||
| features: ['workspace_detail', 'use-case-observability'], |
There was a problem hiding this comment.
Suggested change
| features: ['workspace_detail', 'use-case-observability'], | |
| features: ['use-case-observability'], |
| describe('delete a workspace successfully using action buttons', () => { | ||
| it('should successfully load delete button and show delete modal when clicking action button', () => { | ||
| cy.contains(workspace1Name).should('be.visible'); | ||
| cy.getElementByTestId('euiCollapsedItemActionsButton').first().click(); |
There was a problem hiding this comment.
can we use cy.getElementByTestId(`checkboxSelectRow-${workspaceId}`)
Signed-off-by: Qxisylolo <[email protected]>
SuZhou-Joe
reviewed
Nov 14, 2024
| if (Cypress.env('WORKSPACE_ENABLED')) { | ||
| describe('Delete Workspace(s) in 2 ways in workspace list page', () => { | ||
| before(() => { | ||
| Cypress.config('defaultCommandTimeout', 60000); |
There was a problem hiding this comment.
it is not necessary, I will delete it. Thank you
|
@Qxisylolo Test cases failed, could you please take a look? |
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
SuZhou-Joe
force-pushed
the
add_tests_for_deletion
branch
from
94fa4af to
2b321f9
Compare
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
force-pushed
the
add_tests_for_deletion
branch
from
2b321f9 to
74ffac7
Compare
SuZhou-Joe
approved these changes
Nov 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
* add tests for deletion Signed-off-by: Qxisylolo <[email protected]> * resolve comments Signed-off-by: Qxisylolo <[email protected]> * new update Signed-off-by: Qxisylolo <[email protected]> * new update Signed-off-by: Qxisylolo <[email protected]> * revert lines Signed-off-by: Qxisylolo <[email protected]> --------- Signed-off-by: Qxisylolo <[email protected]> (cherry picked from commit 976f2ba)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Nov 25, 2024
* add tests for deletion Signed-off-by: Qxisylolo <[email protected]> * resolve comments Signed-off-by: Qxisylolo <[email protected]> * new update Signed-off-by: Qxisylolo <[email protected]> * new update Signed-off-by: Qxisylolo <[email protected]> * revert lines Signed-off-by: Qxisylolo <[email protected]> --------- Signed-off-by: Qxisylolo <[email protected]> (cherry picked from commit 976f2ba) Co-authored-by: Qxisylolo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests for workspace deletion, covering three methods:
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.