Skip to content

Commit

Permalink
Updates per PR comments
Browse files Browse the repository at this point in the history
Signed-off-by: Chris Helma <[email protected]>
  • Loading branch information
chelma committed Jan 9, 2025
1 parent 2262d1d commit 7e009a8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 27 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -179,30 +179,5 @@ private void checkDocsWithRouting(
Assertions.assertEquals("1", routing);
}
}

// private static Stream<Arguments> scenarios_experimental() {
// var scenarios = Stream.<Arguments>builder();

// for (var sourceCluster : SupportedClusters.sources()) {
// for (var targetCluster : SupportedClusters.targets_experimental()) {
// scenarios.add(Arguments.of(sourceCluster, targetCluster));
// }
// }

// return scenarios.build();
// }

// @ParameterizedTest(name = "Source {0} to Target {1}")
// @MethodSource(value = "scenarios_experimental")
// public void migrationDocumentsExperimental(
// final SearchClusterContainer.ContainerVersion sourceVersion,
// final SearchClusterContainer.ContainerVersion targetVersion) throws Exception {
// try (
// final var sourceCluster = new SearchClusterContainer(sourceVersion);
// final var targetCluster = new SearchClusterContainer(targetVersion)
// ) {
// migrationDocumentsWithClusters(sourceCluster, targetCluster);
// }
// }


}
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import org.slf4j.LoggerFactory;

public abstract class OpenSearchWorkCoordinator implements IWorkCoordinator {
// Create a stable logger that descendants can use, and we can predictable read from in tests
// Create a stable logger that descendants can use, and we can predictably read from in tests
protected static final Logger log = LoggerFactory.getLogger(OpenSearchWorkCoordinator.class);

public static final String INDEX_NAME = ".migrations_working_state";
Expand Down

0 comments on commit 7e009a8

Please sign in to comment.