Sonarqube Fix - Ensure optional is present before get (#1233)

* Ensure optional is present before `get` * Add specific exception when instantiating a client fails Signed-off-by: Mikayla Thompson <[email protected]>
opensearch-project · Jan 15, 2025 · 8d1678e · 8d1678e
1 parent 37f955c
commit 8d1678e
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/RFS/src/main/java/org/opensearch/migrations/bulkload/common/OpenSearchClientFactory.java b/RFS/src/main/java/org/opensearch/migrations/bulkload/common/OpenSearchClientFactory.java
@@ -46,7 +46,7 @@ public OpenSearchClient determineVersionAndCreate() {
             return clientClass.getConstructor(ConnectionContext.class, Version.class)
                     .newInstance(connectionContext, version);
         } catch (NoSuchMethodException | InstantiationException | IllegalAccessException | InvocationTargetException e) {
-            throw new RuntimeException("Failed to instantiate OpenSearchClient", e);
+            throw new ClientInstantiationException("Failed to instantiate OpenSearchClient", e);
         }
     }
 
@@ -59,7 +59,7 @@ public OpenSearchClient determineVersionAndCreate(RestClient restClient, FailedR
             return clientClass.getConstructor(RestClient.class, FailedRequestsLogger.class, Version.class)
                     .newInstance(restClient, failedRequestsLogger, version);
         } catch (NoSuchMethodException | InstantiationException | IllegalAccessException | InvocationTargetException e) {
-            throw new RuntimeException("Failed to instantiate OpenSearchClient", e);
+            throw new ClientInstantiationException("Failed to instantiate OpenSearchClient", e);
         }
     }
 
@@ -191,9 +191,7 @@ private Mono<Version> getVersionFromNodes(HttpResponse resp) {
 
             if (foundVersions.isEmpty()) {
                 return Mono.error(new OpenSearchClient.OperationFailed("Unable to find any version numbers", resp));
-            }
-
-            if (foundVersions.size() == 1) {
+            } else if (foundVersions.size() == 1) {
                 return Mono.just(foundVersions.stream().findFirst().get());
             }
 
@@ -209,5 +207,10 @@ private Flavor getLikelyOpenSearchFlavor() {
         return client.getConnectionContext().isAwsSpecificAuthentication() ? Flavor.AMAZON_MANAGED_OPENSEARCH : Flavor.OPENSEARCH;
     }
 
+    public static class ClientInstantiationException extends RuntimeException {
+        public ClientInstantiationException(String message, Exception cause) {
+            super(message, cause);
+        }
+    }
 
 }