Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist. #61
Conversation
dblock
requested review from
sam-herman,
saratvemulapalli,
VachaShah,
kotwanikunal,
andrross and
anasalkouz
as code owners
|
Build should be fixed by #62 |
dblock
force-pushed
the
update-pull-request-template
branch
from
da31cc6 to
e600b40
Compare
|
@dblock could you rebase please? thank you |
…cklist. Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
update-pull-request-template
branch
from
e600b40 to
31d5e1d
Compare
|
@dblock Eh, I'm not sure about this PR. I dislike unnecessary boilerplate, and it strikes me as unlikely that a repository plugin would ever need to implement a user-facing API that would require a change to the specification. |
|
@andrross If you don't think this plugin will ever implement a REST API then we can just close it. Your call! |
@dblock Upon further thought, repository implementations do define settings that go into the payload of a request to a core API and therefore are probably fair game for defining in the API specification. |
|
Can any current maintainers please merge this? @samuel-oci @anasalkouz @VachaShah? |
Coming from opensearch-project/opensearch-api-specification#387, update PR template to include a checkbox that requests that all API changes be documented in the OpenAPI spec used to generate clients.