Basic templates and addition of build steps #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgodwan
force-pushed
the
templates-basic
branch
2 times, most recently
from
45573c1 to
db23ce4
Compare
Signed-off-by: Mohit Godwani <[email protected]>
backslasht
requested changes
Jul 18, 2024
src/main/java/org/opensearch/system/applicationtemplates/LocalSystemTemplateRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/system/applicationtemplates/LocalSystemTemplateRepository.java
Show resolved
Hide resolved
src/main/java/org/opensearch/system/applicationtemplates/LocalSystemTemplateRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/system/applicationtemplates/LocalSystemTemplateRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/system/applicationtemplates/LocalSystemTemplateRepository.java
Show resolved
Hide resolved
src/main/java/org/opensearch/system/applicationtemplates/LocalSystemTemplateRepository.java
Show resolved
Hide resolved
src/main/resources/org/opensearch/system/applicationtemplates/logs-general.json
Outdated
Show resolved
Hide resolved
src/main/resources/org/opensearch/system/applicationtemplates/logs-general.json
Outdated
Show resolved
Hide resolved
...test/java/org/opensearch/system/applicationtemplates/LocalSystemTemplateRepositoryTests.java
Show resolved
Hide resolved
...erTest/java/org/opensearch/system/applicationtemplates/CreateIndexTemplateWithContextIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mohit Godwani <[email protected]>
Signed-off-by: Mohit Godwani <[email protected]>
backslasht
requested changes
Jul 23, 2024
...ensearch/system/applicationtemplates/ApplicationBasedConfigurationSystemTemplatesPlugin.java
Show resolved
Hide resolved
src/main/java/org/opensearch/system/applicationtemplates/LocalSystemTemplateRepository.java
Show resolved
Hide resolved
src/main/java/org/opensearch/system/applicationtemplates/LocalSystemTemplateRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/system/applicationtemplates/LocalSystemTemplateRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/system/applicationtemplates/LocalSystemTemplateRepository.java
Outdated
Show resolved
Hide resolved
src/main/resources/org/opensearch/system/applicationtemplates/templates.json
Show resolved
Hide resolved
Signed-off-by: Mohit Godwani <[email protected]>
mgodwan
commented
Jul 24, 2024
| public class CreateIndexTemplateWithContextTemplateIT extends OpenSearchRestTestCase { | ||
|
|
||
| public void testCreateIndexWithContextBasedTemplate() throws IOException { | ||
| // TODO: Add E2E test with rest layer here. |
There was a problem hiding this comment.
This will be added once the nightly run of core snapshot repo is available, as the test will keep failing otherwise,
backslasht
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basic templates and addition of build steps
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.