Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Bump netty to match version from core's buildSrc/version.properties and bump grpc to 1.56.1 #546

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Apr 20, 2024

Is your feature request related to a problem? Please provide an existing Issue # , or describe.

This PR will match the build.gradle file on main here: https://github.com/opensearch-project/performance-analyzer-rca/blob/main/build.gradle#L373-L377

The dependencies on main should be updated or dependabot added to this repo if its not enabled already.

Without this change performance-analyzer-rca is being bundled with netty-codec-http-4.1.87.Final.jar, netty-codec-http2-4.1.87.Final.jar and netty-handler-4.1.87.Final.jar which are affected by https://avd.aquasec.com/nvd/cve-2024-29025, GHSA-xpw8-rcwv-8f8p and https://avd.aquasec.com/nvd/cve-2023-34462 respectively.

Check List

  • Backport Labels added.
  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cwperks added 2 commits April 19, 2024 20:19
Signed-off-by: Craig Perkins <[email protected]>
@kkhatua kkhatua requested a review from dzane17 April 22, 2024 18:31
@bbarani
Copy link
Member

bbarani commented Apr 22, 2024

@sgup432 can you please review it?

@sgup432
Copy link
Contributor

sgup432 commented Apr 22, 2024

@cwperks
I see main branch has implementation 'io.grpc:grpc-stub:1.52.1', do we need to update it to 1.56.1 there as well?

@cwperks
Copy link
Member Author

cwperks commented Apr 22, 2024

@sgup432 Yes, main needs to be updated as well. I opened up a PR to add dependabot to automatically monitor for outdated dependencies and create PRs.

In the previous commit I made this PR exactly match main and it gave the following error:

Execution failed for task ':updateShas'.
> Could not resolve all dependencies for configuration ':runtimeClasspath'.
   > Conflict(s) found for the following module(s):
       - io.grpc:grpc-api between versions 1.56.1 and 1.52.1
     Run with:
         --scan or
         :dependencyInsight --configuration runtimeClasspath --dependency io.grpc:grpc-api
     to get more insight on how to solve the conflict.

ref: https://github.com/opensearch-project/performance-analyzer-rca/actions/runs/8761123266/job/24047189857?pr=546

@cwperks cwperks merged commit 8bd64c0 into opensearch-project:1.3 Apr 22, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants