Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSCI-23] Add vchrombie as an author #2033

Merged
merged 1 commit into from
Sep 22, 2023
Merged

[OSCI-23] Add vchrombie as an author #2033

merged 1 commit into from
Sep 22, 2023

Conversation

vchrombie
Copy link
Contributor

Description

Add vchrombie as an author

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@vchrombie vchrombie force-pushed the chore/vchrombie-author branch from 2b53ab3 to 756431a Compare September 21, 2023 16:48
@vchrombie
[OSCI-23] Add vchrombie as an author
319e616 
Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
@vchrombie vchrombie force-pushed the chore/vchrombie-author branch from 756431a to 319e616 Compare September 21, 2023 16:56
dtaivpp
dtaivpp approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@dtaivpp dtaivpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you noticed we have a few errors that were checked by our style workflow step. This is okay in your case as they were all false positives. Looks good!

@vchrombie
Copy link
Contributor Author

If you noticed we have a few errors that were checked by our style workflow step. This is okay in your case as they were all false positives. Looks good!

Thanks for the review.

dtaivpp
dtaivpp approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@dtaivpp dtaivpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dtaivpp dtaivpp merged commit ebaf032 into opensearch-project:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtaivpp dtaivpp dtaivpp approved these changes

@elfisher elfisher Awaiting requested review from elfisher elfisher is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@krisfreedain krisfreedain Awaiting requested review from krisfreedain krisfreedain is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@nateynateynate nateynateynate Awaiting requested review from nateynateynate nateynateynate is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchrombie @dtaivpp