Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brian Park profile page created #2035

Closed
wants to merge 1 commit into from
Closed

Brian Park profile page created #2035

wants to merge 1 commit into from

Conversation

brian-jw-park
Copy link
Contributor

Description

Adds Brian Park profile page

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

ashwin-pc
ashwin-pc suggested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this to the _authors/osci_2023 folder. My instructions in the gist were incorrect so apologies for that.

@brian-jw-park
Copy link
Contributor Author

can you move this to the _authors/osci_2023 folder. My instructions in the gist were incorrect so apologies for that.

Hi Ashwin! I just had a quick question–to solve this, I was thinking of just repeating the entire process we covered on Day 2 and then creating my new file under _authors/osci_2023. I was wondering whether there was a simpler command to do this? I feel like git move could work but I was having trouble getting it to work successfully. Thank you!

@dtaivpp
Copy link
Collaborator

dtaivpp commented Sep 25, 2023

So typically the move command on most systems is mv start_file_dest end_file_dest

nateynateynate
nateynateynate requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@nateynateynate nateynateynate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Brian! Mind dropping your author file into _authors/osci_2023 instead of in the base _authors folder? Thanks!

@dtaivpp
Copy link
Collaborator

dtaivpp commented Oct 19, 2023

Closing as requested changes were not made and we are past deadlines

@dtaivpp dtaivpp closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateynateynate nateynateynate nateynateynate requested changes

@ashwin-pc ashwin-pc ashwin-pc requested changes

@elfisher elfisher Awaiting requested review from elfisher elfisher is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@krisfreedain krisfreedain Awaiting requested review from krisfreedain krisfreedain is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dtaivpp dtaivpp Awaiting requested review from dtaivpp dtaivpp is a code owner

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brian-jw-park @dtaivpp @ashwin-pc @nateynateynate