add new osci author frankschlehofer-pc #2042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank <[email protected]>
frankschlehofer
requested review from
elfisher,
AMoo-Miki,
nknize,
krisfreedain,
peterzhuamazon,
CEHENKLE,
dtaivpp,
kolchfa-aws and
nateynateynate
as code owners
ashwin-pc
reviewed
Sep 21, 2023
| github: <frankschlehofer> | ||
| --- | ||
|
|
||
| **<Frankie Schlehofer>** <Something about you!> |
There was a problem hiding this comment.
@frankschlehofer Can you add something bout yourself here
ashwin-pc
reviewed
Sep 21, 2023
Comment on lines
+2
to
+5
| name: <Frank Schlehofer> | ||
| short_name: Frankie | ||
| twitter: <twitter handle without the @> | ||
| github: <frankschlehofer> |
There was a problem hiding this comment.
Suggested change
| name: <Frank Schlehofer> | |
| short_name: Frankie | |
| twitter: <twitter handle without the @> | |
| github: <frankschlehofer> | |
| name: Frank Schlehofer | |
| short_name: Frankie | |
| github: frankschlehofer |
Can you make the following changes?
|
@frankschlehofer can you please do the changes requested above? Thank you! |
|
Closing as requested changes were not made and we are past deadlines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new osci author author to the repository
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.