[OSCI] Add new osci author kenny zhang #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinlin Zhang <[email protected]>
kennyzhang0819
requested review from
elfisher,
AMoo-Miki,
nknize,
krisfreedain,
peterzhuamazon,
CEHENKLE,
dtaivpp,
kolchfa-aws and
nateynateynate
as code owners
ashwin-pc
suggested changes
Sep 21, 2023
There was a problem hiding this comment.
@kennyzhang0819 can you move the file to _authors/osci_2023? Sorry there was a mistake in my instructions. Apologies for that.
|
@kennyzhang0819 you are missing the signoff on that latest commit. Can you run this to resolve:
|
Signed-off-by: Jinlin Zhang <[email protected]>
Signed-off-by: Kris Freedain <[email protected]> Signed-off-by: Jinlin Zhang <[email protected]>
Signed-off-by: Kris Freedain <[email protected]> Signed-off-by: Jinlin Zhang <[email protected]>
Signed-off-by: Jinlin Zhang <[email protected]>
kennyzhang0819
force-pushed
the
chore/kenny-pc
branch
from
11dc292 to
52532bb
Compare
|
Hi, can you check again and see if this is correct? Also, I realized there are two pull requests, should I close the other one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added new osci author kenny zhang (myself)
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.